damccorm commented on code in PR #27930:
URL: https://github.com/apache/beam/pull/27930#discussion_r1288764130
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -1906,15 +1906,14 @@ def validate_transform(transform_id):
raise ValueError(
"Bad coder for output of %s: %s" % (transform_id, output_coder))
output_values_coder = pipeline_proto.components.coders[
- output_coder.component_coder_ids[1]]
- if (input_coder.component_coder_ids[0] !=
- output_coder.component_coder_ids[0] or
- output_values_coder.spec.urn != common_urns.coders.ITERABLE.urn or
- output_values_coder.component_coder_ids[0] !=
- input_coder.component_coder_ids[1]):
- raise ValueError(
- "Incompatible input coder %s and output coder %s for transform %s"
%
- (transform_id, input_coder, output_coder))
+ output_coder.component_coder_ids[1]]
+ if (input_coder.component_coder_ids[0] !=
output_coder.component_coder_ids[0]):
+ raise ValueError("Input coder key does not match output coder key for
transform %s" %
Review Comment:
Can we include the coder keys in this error (and similarly include the bad
pieces in the other errors)
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -1906,15 +1906,14 @@ def validate_transform(transform_id):
raise ValueError(
"Bad coder for output of %s: %s" % (transform_id, output_coder))
output_values_coder = pipeline_proto.components.coders[
- output_coder.component_coder_ids[1]]
- if (input_coder.component_coder_ids[0] !=
- output_coder.component_coder_ids[0] or
- output_values_coder.spec.urn != common_urns.coders.ITERABLE.urn or
- output_values_coder.component_coder_ids[0] !=
- input_coder.component_coder_ids[1]):
- raise ValueError(
- "Incompatible input coder %s and output coder %s for transform %s"
%
- (transform_id, input_coder, output_coder))
+ output_coder.component_coder_ids[1]]
+ if (input_coder.component_coder_ids[0] !=
output_coder.component_coder_ids[0]):
+ raise ValueError("Input coder key does not match output coder key for
transform %s" %
+ (transform_id))
+ if(output_values_coder.spec.urn != common_urns.coder.ITERABLE.urn):
Review Comment:
```suggestion
if(output_values_coder.spec.urn != common_urns.coders.ITERABLE.urn):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
