mrkm4ntr commented on code in PR #26424:
URL: https://github.com/apache/beam/pull/26424#discussion_r1289632381
##########
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##########
@@ -1224,26 +1241,9 @@ static class DefaultRetryPredicate implements
RetryPredicate {
this(429);
}
- /** Returns true if the response has the error code for any mutation. */
- private static boolean errorCodePresent(HttpEntity responseEntity, int
errorCode) {
Review Comment:
Thanks.
So, you believe there's a scenario where the HTTP status code is 200, but
the status in the body is 429. I'm not certain this is accurate, but we should
pay attention to this if we're not confident.
OK, I will change my PR like this.
> Checking the http status code first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
