mosche commented on code in PR #27484:
URL: https://github.com/apache/beam/pull/27484#discussion_r1292797101
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsIO.java:
##########
@@ -709,8 +789,9 @@ private class Dynamic extends Batches {
(queue, batch) -> batch != null && batch.lock(true) ? batch :
createLocked(queue);
private final Map<@NonNull String, Batch> batches = new HashMap<>();
+ private final AtomicBoolean submitExpiredRunning = new
AtomicBoolean(false);
Review Comment:
The class is not entirely thread-safe, but certain operations have to be,
e.g. `submitExpired(boolean throwFailures)` to prevent multiple concurrent
executions if a loop takes longer than the trigger interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
