TobKed commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r465736828
##########
File path: sdks/python/apache_beam/io/parquetio_test.py
##########
@@ -296,8 +296,10 @@ def test_sink_transform_int96(self):
path, self.SCHEMA96, num_shards=1, shard_name_template='')
def test_sink_transform(self):
- with tempfile.NamedTemporaryFile() as dst:
- path = dst.name
+ fd, path = tempfile.mkstemp()
Review comment:
There was problem on windows since `with tempfile.NamedTemporaryFile()
as dst` provide `tempfile` which is already opened. On windows any opened file
seems to be read only which coused PermissionError. I know this workaround is
ugly but it the best way I found to do it.
Is separate commit with JIRA will not be lost after merging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
