kennknowles commented on code in PR #28066: URL: https://github.com/apache/beam/pull/28066#discussion_r1299238038
########## sdks/python/apache_beam/runners/dataflow/dataflow_runner.py: ########## @@ -648,7 +648,7 @@ def __init__(self, side_input): class DataflowPipelineResult(PipelineResult): """Represents the state of a pipeline run on the Dataflow service.""" - def __init__(self, job, runner): + def __init__(self, job, options, runner): Review Comment: Yea it would have made my change smaller too. FWIW this class is not intended for public. I may be rusty on how `__all__` works. But this class definitely should only be constructed from within the DataflowRunner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
