George-Wu commented on a change in pull request #12473: URL: https://github.com/apache/beam/pull/12473#discussion_r466109042
########## File path: sdks/python/apache_beam/io/gcp/dicomio_integration_test.py ########## @@ -0,0 +1,155 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +Integration test for Google Cloud DICOM IO connector. +""" +# pytype: skip-file + +from __future__ import absolute_import + +import json +import time +import unittest + +from google.auth import default +from google.auth.transport import requests +from google.cloud import storage +from nose.plugins.attrib import attr + +import apache_beam as beam +from apache_beam.io import fileio +from apache_beam.io.gcp.dicomio import DicomSearch +from apache_beam.io.gcp.dicomio import UploadToDicomStore +from apache_beam.testing.test_pipeline import TestPipeline +from apache_beam.testing.util import assert_that +from apache_beam.testing.util import equal_to + +REGION = 'us-central1' +DATA_SET_ID = 'apache-beam-integration-testing' +HEALTHCARE_BASE_URL = 'https://healthcare.googleapis.com/v1' +PERSISTENT_DICOM_STORE_NAME = "dicom_it_persistent_store" +DICOM_FILES_PATH = "gs://temp-storage-for-dicom-io-tests/dicom_files" +NUM_INSTANCE = 18 + + +def create_dicom_store(project_id, dataset_id, region, dicom_store_id): + # Create a an empty DICOM store + credential, _ = default() + session = requests.AuthorizedSession(credential) + api_endpoint = "{}/projects/{}/locations/{}".format( + HEALTHCARE_BASE_URL, project_id, region) + + # base of dicomweb path. + dicomweb_path = "{}/datasets/{}/dicomStores".format(api_endpoint, dataset_id) + + response = session.post( + dicomweb_path, params={"dicomStoreId": dicom_store_id}) + response.raise_for_status() + return response.status_code + + +def delete_dicom_store(project_id, dataset_id, region, dicom_store_id): + # Delete an existing DICOM store + credential, _ = default() + session = requests.AuthorizedSession(credential) + api_endpoint = "{}/projects/{}/locations/{}".format( + HEALTHCARE_BASE_URL, project_id, region) + + # base of dicomweb path. + dicomweb_path = "{}/datasets/{}/dicomStores/{}".format( + api_endpoint, dataset_id, dicom_store_id) + + response = session.delete(dicomweb_path) + response.raise_for_status() + return response.status_code + + +class DICOMIoIntegrationTest(unittest.TestCase): Review comment: I think maybe a test of pub/sub is unnecessary here because our connector has no direct dependency or invocation of pub/sub. The 'pubsub to search metadata' converter was tested in the unit test while read and write operations can be tested in an easier way here rather than using pub/sub. What's more, testing a streaming pipeline is complicated and needs much more work :( ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
