lostluck commented on code in PR #28343:
URL: https://github.com/apache/beam/pull/28343#discussion_r1317946366
##########
release/src/main/scripts/publish_docker_images.sh:
##########
@@ -37,34 +37,22 @@ echo "Which release candidate will be the source of final
docker images? (ex: 1)
read RC_NUM
RC_VERSION="rc${RC_NUM}"
-echo "================Pull RC Containers from DockerHub==========="
-IMAGES=$(docker search
${DOCKER_IMAGE_DEFAULT_REPO_ROOT}/${DOCKER_IMAGE_DEFAULT_REPO_PREFIX} --format
"{{.Name}}" --limit 100)
-KNOWN_IMAGES=()
-echo "We are using ${RC_VERSION} to push docker images for ${RELEASE}."
-while read IMAGE; do
- # Try pull verified RC from dockerhub.
- if docker pull "${IMAGE}:${RELEASE}${RC_VERSION}" 2>/dev/null ; then
- KNOWN_IMAGES+=( $IMAGE )
- fi
-done < <(echo "${IMAGES}")
-
echo "================Confirming Release and RC version==========="
+ALL_IMAGES=$(docker search
${DOCKER_IMAGE_DEFAULT_REPO_ROOT}/${DOCKER_IMAGE_DEFAULT_REPO_PREFIX} --filter
tag=${RELEASE}${RC_VERSION} --format "{{.Name}}" --limit 100)
Review Comment:
```suggestion
ALL_IMAGES=$(docker search
${DOCKER_IMAGE_DEFAULT_REPO_ROOT}/${DOCKER_IMAGE_DEFAULT_REPO_PREFIX} --filter
tag=${RELEASE}${RC_VERSION} --format "{{.Name}}" --limit 100)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
