leiyiz commented on a change in pull request #12427:
URL: https://github.com/apache/beam/pull/12427#discussion_r466704612
##########
File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/query1.py
##########
@@ -29,20 +29,16 @@
import apache_beam as beam
from apache_beam.testing.benchmarks.nexmark.models import nexmark_model
-from apache_beam.testing.benchmarks.nexmark.nexmark_util import ParseEventFn
-from apache_beam.testing.benchmarks.nexmark.nexmark_util import display
+from apache_beam.testing.benchmarks.nexmark.queries import nexmark_query_util
def load(raw_events, query_args=None):
return (
raw_events
- | 'ParseEventFn' >> beam.ParDo(ParseEventFn())
- | 'FilterInBids' >>
- beam.Filter(lambda event: isinstance(event, nexmark_model.Bid))
+ | nexmark_query_util.JustBids()
| 'ConvertToEuro' >> beam.Map(
lambda bid: nexmark_model.Bid(
bid.auction,
- bid.bidder, (float(bid.price) * 89) // 100,
- bid.timestamp,
- bid.extra))
- | 'DisplayQuery1' >> beam.Map(display)) # pylint:
disable=expression-not-assigned
+ bid.bidder, (bid.price * 89) // 100,
Review comment:
no problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
