damondouglas commented on code in PR #28274:
URL: https://github.com/apache/beam/pull/28274#discussion_r1325047291
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -669,9 +668,17 @@ public GenericDatumTransformer(
String tableSchema,
org.apache.avro.Schema writer) {
this.parseFn = parseFn;
- this.tableSchema =
- Suppliers.memoize(
- Suppliers.compose(new TableSchemaFunction(),
Suppliers.ofInstance(tableSchema)));
+ this.tableSchema = new TableSchemaFunction().apply(tableSchema);
Review Comment:
Thank you for this suggestion. It was needed to convert the JSON string
constructor parameter into a TableSchema. I felt that since the method was
public, we needed to still support it and thus needed this conversion using
TableSchemaFunction. @Abacn in light of this context, do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
