damccorm commented on code in PR #28553:
URL: https://github.com/apache/beam/pull/28553#discussion_r1331668422
##########
sdks/typescript/package.json:
##########
@@ -36,7 +36,7 @@
},
"dependencies": {
"@google-cloud/pubsub": "^2.19.4",
- "@grpc/grpc-js": "^1.8.8",
+ "@grpc/grpc-js": "^1.4.6",
Review Comment:
I'm kinda confused by this one: isn't `^1.4.6` just a more permissive
superset of `^1.8.8`? Should we be pinning to an explicit version instead of
using the `^`?
In semver `^1.4.6` is equivalent to `>=1.4.6, <2.0.0`
##########
sdks/typescript/src/apache_beam/runners/dataflow.ts:
##########
@@ -33,6 +33,8 @@ export function dataflowRunner(runnerOptions: {
options: Object = {}
): Promise<PipelineResult> {
var augmentedOptions = { experiments: [] as string[], ...options };
+ augmentedOptions.experiments.push("use_runner_v2");
+ augmentedOptions.experiments.push("use_portable_job_submission");
Review Comment:
Would typescript tests have caught this? If yes, should we add python runner
paths to the workflow trigger so that the tests run against python dataflow
runner changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
