je-ik commented on issue #28554:
URL: https://github.com/apache/beam/issues/28554#issuecomment-1730987899
From my understanding, using `stop` with `--savepoint` and `--drain`, then
this should result in the following sequence:
a) sources stop emitting data
b) MAX_WATERMARK is emitted
c) savepoint is taken
d) job is terminated
This would IMO result in correct job termination, what seems questionable is
this sentence from the docs:
```
The job will keep running until all sources properly shut down. This allows
the job to finish processing all in-flight data, which can produce some records
to process after the savepoint taken while stopping.
```
If there is some possibility that some data is emitted *after* the
savepoint, then this violates the requirements we have for
@RequiresStableInput.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
