bvolpato commented on code in PR #28513:
URL: https://github.com/apache/beam/pull/28513#discussion_r1337975993
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -2027,6 +2034,10 @@ private void updateVMMetrics() {
private void updateThreadMetrics() {
timeAtMaxActiveThreads.getAndReset();
timeAtMaxActiveThreads.addValue(workUnitExecutor.allThreadsActiveTime());
+ activeThreads.getAndReset();
+ activeThreads.addValue(workUnitExecutor.activeCount());
+ maxActiveThreads.getAndReset();
+ maxActiveThreads.addValue(chooseMaximumNumberOfThreads());
Review Comment:
If you make above `intMax`, I believe here we should use
`workUnitExecutor.activeCount()` as well?
Otherwise it's just a different metric for `numberOfWorkerHarnessThreads`?
Not actual max utilized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
