lukecwik commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467326804
##########
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/OutputAndTimeBoundedSplittableProcessElementInvokerTest.java
##########
@@ -126,23 +128,30 @@ public void outputWindowedValue(
NullSideInputReader.empty(),
Executors.newSingleThreadScheduledExecutor(),
1000,
- Duration.standardSeconds(3));
-
- return invoker.invokeProcessElement(
- DoFnInvokers.invokerFor(fn),
- WindowedValue.of(null, Instant.now(), GlobalWindow.INSTANCE,
PaneInfo.NO_FIRING),
- new OffsetRangeTracker(initialRestriction),
- new WatermarkEstimator<Void>() {
- @Override
- public Instant currentWatermark() {
- return GlobalWindow.TIMESTAMP_MIN_VALUE;
- }
+ Duration.standardSeconds(3),
+ () -> bundleFinalizer);
+
+ SplittableProcessElementInvoker.Result rval =
+ invoker.invokeProcessElement(
+ DoFnInvokers.invokerFor(fn),
+ WindowedValue.of(null, Instant.now(), GlobalWindow.INSTANCE,
PaneInfo.NO_FIRING),
+ new OffsetRangeTracker(initialRestriction),
+ new WatermarkEstimator<Void>() {
+ @Override
+ public Instant currentWatermark() {
+ return GlobalWindow.TIMESTAMP_MIN_VALUE;
+ }
- @Override
- public Void getState() {
- return null;
- }
- });
+ @Override
+ public Void getState() {
+ return null;
+ }
+ });
+ for (InMemoryBundleFinalizer.Finalization finalization :
+ bundleFinalizer.getAndClearFinalizations()) {
+ finalization.getCallback().onBundleSuccess();
Review comment:
We don't. I originally thought we did for some reason since I was
changing this code together. I removed it and instead throw if it is ever
accessed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
