hjtran commented on code in PR #28984:
URL: https://github.com/apache/beam/pull/28984#discussion_r1358325019
##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -674,13 +674,20 @@ def apply(
alter_label_if_ipython(transform, pvalueish)
full_label = '/'.join(
- [self._current_transform().full_label, label or
- transform.label]).lstrip('/')
+ [self._current_transform().full_label, transform.label]).lstrip('/')
Review Comment:
Just want to highlight this change since it's not exactly necessary for the
behavior change described in this PR. This `label or` clause should always
evaluate `False` since the truthiness of `label` is already evaluated a few
lines up and results in an early return if True.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
