andreydevyatkin commented on code in PR #28960: URL: https://github.com/apache/beam/pull/28960#discussion_r1360768586
########## .github/workflows/load-tests-job-configs/beam_LoadTests_Go_GBK_Dataflow_Batch_100b.txt: ########## @@ -1,4 +1,3 @@ -############################################################################### Review Comment: Since we're updating `.txt` files as well, can we name it as `go_GBK_Dataflow_Batch_*.txt`? ########## .github/workflows/load-tests-job-configs/beam_LoadTests_Go_GBK_Dataflow_Batch_100b.txt: ########## @@ -13,8 +12,8 @@ # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and -# limitations under the License. -############################################################################### +# limitations under the License. + --job_name=load-tests-go-dataflow-batch-gbk-2- --project=apache-beam-testing Review Comment: Can we remove `--project`, `--influx_db_name` and `--influx_hostname` since they are general options and are being applied at runtime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
