bvolpato commented on code in PR #29015:
URL: https://github.com/apache/beam/pull/29015#discussion_r1361111071
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -134,6 +134,12 @@ public PCollection<Row> expand(PBegin input) {
if (partitions != null) {
readRows = readRows.withNumPartitions(partitions);
}
+
+ @Nullable Short fetchSize = config.getInt16("fetchSize");
Review Comment:
Yes, I found it strange but just replicated what was in the non-partitioned.
I think making it clearer and switching the default to int16_max instead of
50000 would make more sense, and make JdbcIO more usable / drop-in for most
databases (since we reportedly had issues when some databases went over it).
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
