damccorm commented on code in PR #29034:
URL: https://github.com/apache/beam/pull/29034#discussion_r1362735637


##########
.github/workflows/beam_LoadTests_Python_CoGBK_Dataflow_Batch.yml:
##########
@@ -79,10 +79,10 @@ jobs:
           test-type: load
           test-language: python
           argument-file-paths: |
-            ${{ github.workspace 
}}/.github/workflows/load-tests-job-configs/python-cogbk/python_CoGBK_Dataflow_Batch_100b_Single_Key.txt
-            ${{ github.workspace 
}}/.github/workflows/load-tests-job-configs/python-cogbk/python_CoGBK_Dataflow_Batch_100b_Multiple_Keys.txt
-            ${{ github.workspace 
}}/.github/workflows/load-tests-job-configs/python-cogbk/python_CoGBK_Dataflow_Batch_10kB.txt
-            ${{ github.workspace 
}}/.github/workflows/load-tests-job-configs/python-cogbk/python_CoGBK_Dataflow_Batch_2MB.txt
+            ${{ github.workspace 
}}/.github/workflows/load-tests-job-configs/python_CoGBK_Dataflow_Batch_100b_Single_Key.txt
+            ${{ github.workspace 
}}/.github/workflows/load-tests-job-configs/python_CoGBK_Dataflow_Batch_100b_Multiple_Keys.txt
+            ${{ github.workspace 
}}/.github/workflows/load-tests-job-configs/python_CoGBK_Dataflow_Batch_10kB.txt
+            ${{ github.workspace 
}}/.github/workflows/load-tests-job-configs/python_CoGBK_Dataflow_Batch_2MB.txt

Review Comment:
   What was the issue we're fixing here? Are paths too long?
   
   I like the per directory organization, if file length is the issue maybe we 
could do something like `${{ github.workspace 
}}/.github/workflows/load-tests-job-configs/python-cogbk/dataflow_Batch_2MB.txt`
 which truncates to basically the same length



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to