saavannanavati commented on pull request #12352: URL: https://github.com/apache/beam/pull/12352#issuecomment-671741215
> The problem with this function is that it's called on all sorts of operations, even those without type constraints, when it applies to only one kind of operation. This pattern (and the heavy use of hasattr) suggests it'd be better to make this a method on Operation, say with default of return None. That makes sense, just pushed fixes with these design changes. PTAL @robertwb ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
