je-ik commented on code in PR #29102: URL: https://github.com/apache/beam/pull/29102#discussion_r1368205408
########## website/www/site/layouts/shortcodes/flink_java_pipeline_options.html: ########## @@ -22,6 +22,11 @@ <td>Flag indicating whether non restored state is allowed if the savepoint contains state for an operator that is no longer part of the pipeline.</td> <td>Default: <code>false</code></td> </tr> +<tr> + <td><code>attachedMode</code></td> Review Comment: Dtto ########## website/www/site/layouts/shortcodes/flink_python_pipeline_options.html: ########## @@ -92,6 +107,11 @@ <td>Address of the Flink Master where the Pipeline should be executed. Can either be of the form "host:port" or one of the special values [local], [collection] or [auto].</td> <td>Default: <code>[auto]</code></td> </tr> +<tr> + <td><code>job_check_interval_in_secs</code></td> Review Comment: Same here. ########## website/www/site/layouts/shortcodes/flink_java_pipeline_options.html: ########## @@ -92,6 +107,11 @@ <td>Address of the Flink Master where the Pipeline should be executed. Can either be of the form "host:port" or one of the special values [local], [collection] or [auto].</td> <td>Default: <code>[auto]</code></td> </tr> +<tr> + <td><code>jobCheckIntervalInSecs</code></td> Review Comment: Dtto. ########## website/www/site/layouts/shortcodes/flink_python_pipeline_options.html: ########## @@ -77,6 +87,11 @@ <td>Remove unneeded deep copy between operators. See https://issues.apache.org/jira/browse/BEAM-11146</td> <td>Default: <code>false</code></td> </tr> +<tr> + <td><code>file_input_split_max_size_m_b</code></td> Review Comment: Can you please remove these unrelated changes? I understand it has been generated by a generator, but it would be better to keep the PR clean and focused on the single change. ########## website/www/site/layouts/shortcodes/flink_python_pipeline_options.html: ########## @@ -22,6 +22,11 @@ <td>Flag indicating whether non restored state is allowed if the savepoint contains state for an operator that is no longer part of the pipeline.</td> <td>Default: <code>false</code></td> </tr> +<tr> + <td><code>attached_mode</code></td> Review Comment: Dtto ########## website/www/site/layouts/shortcodes/flink_java_pipeline_options.html: ########## @@ -77,6 +87,11 @@ <td>Remove unneeded deep copy between operators. See https://issues.apache.org/jira/browse/BEAM-11146</td> <td>Default: <code>false</code></td> </tr> +<tr> + <td><code>fileInputSplitMaxSizeMB</code></td> Review Comment: Dtto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
