Abacn commented on code in PR #27598:
URL: https://github.com/apache/beam/pull/27598#discussion_r1368808465
##########
sdks/java/io/neo4j/src/main/java/org/apache/beam/sdk/io/neo4j/Neo4jIO.java:
##########
@@ -1126,11 +1155,11 @@ private WriteUnwindFn(
public void processElement(ProcessContext context) {
// Map the input data to the parameters map...
//
- ParameterT parameters = context.element();
+ KV<Integer, ParameterT> parameters = context.element();
Review Comment:
It still looks a bit unuaual to me
- A `Reshuffle.AssignShardFn(parallelism)` is used to map Element ->
KV<Integer, Elemenr>, but in the downstream it just takes value, within same
fused stage
- The DoFn output type changes from Void to ParameterT, but WriteUnwindFn
still does not output anything
i.e. both change modifies the API but still no-op. Are they intended? WIll
there be follow up tasks? CC: @bvolpato @fbiville
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
