Abacn commented on code in PR #29151:
URL: https://github.com/apache/beam/pull/29151#discussion_r1373681014


##########
.test-infra/metrics/sync/github/sync_workflows.py:
##########
@@ -55,6 +55,26 @@ def __init__(self, id, name, filename):
     self.filename = filename
     self.runs = []
 
+def get_dashboard_category(workflow_name):

Review Comment:
   this is generally good though for cross-lang it is subtle, e.g. 
"PythonUsingJava". We can always come back latter.
   
   What's your opinion of keep current structure (used in workflow MDs for GHA 
or Jenkins) that is having PreCommit PostCommit LoadTest PerformanceTest Others
   
   I remember we had discussion replacing precommit/postcommit terms but 
currently the idea is have a easy way sort out the development blocking test 
failures (currently labeled as precommit); release blocking test failures 
(currently labeled as precommit and postcommit) which are most important ones



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to