Abacn opened a new pull request, #29182: URL: https://github.com/apache/beam/pull/29182
Resolve https://stackoverflow.com/questions/77317904/apache-beam-python-sdk-reading-from-postgres-using-jdbc-io Some context: This has been a long-standing issue. MillisInstant is a logical type that backs Java's DATETIME type in schema (in Java side, its language type is a Joda Instant). In Beam portable framework, DATETIME is no longer a primitive type (true for Python, Go but not for Java), but rather a logical type backed by a MicrosInstant. Its language type is a Java.time.Instant (due to joda is in maintenance mode and there is plan to replace to java.time.Instant. This would be a breaking change and milestoned at next major version). As such, Java SDK still uses DATETIME primitive in schema. MillisInstant logical type was then a workaround introduced, to enable Python xlang JdbcIO to r/w rows contain Timestamps. But it need to register the MillisInstant to overwrite the default mapping (MicrosInstant) --- That is what currently the integration does. Since this has been a pain point. It may worth to include this line in the jdbc module. It will then make the MillisInstant supersedes MicrosInstant when jdbc module is imported. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
