robertwb commented on code in PR #29171:
URL: https://github.com/apache/beam/pull/29171#discussion_r1376697875
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -700,9 +700,25 @@ def __init__(self, transforms, mappings,
underlying_provider, defaults=None):
for transform in transforms.keys():
if transform not in mappings:
raise ValueError(f'Missing transform {transform} in mappings.')
- self._mappings = mappings
+ self._mappings = self.get_mappings_from_transform(mappings)
Review Comment:
Maybe call this "validate_mappings" or "expand_mappings" to make the intent
more clear?
##########
sdks/java/io/jdbc/build.gradle:
##########
@@ -33,6 +33,10 @@ dependencies {
implementation library.java.joda_time
implementation "org.apache.commons:commons-pool2:2.11.1"
implementation library.java.slf4j_api
+ implementation 'org.postgresql:postgresql:42.6.0'
Review Comment:
I'm not sure we want to add all of these to the base jdbc package--I think
the intent was for the user to provide their own dependencies.
On the other hand, I can see it'd be really handy for cross-langauge users
not to have to specify this. Perhaps these dependencies could be added to the
expansion service instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
