m-trieu commented on code in PR #29445:
URL: https://github.com/apache/beam/pull/29445#discussion_r1394866391
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/HistogramData.java:
##########
@@ -58,6 +61,8 @@ public HistogramData(BucketType bucketType) {
this.numBoundedBucketRecords = 0;
this.numTopRecords = 0;
this.numBottomRecords = 0;
+ this.mean = 0;
+ this.sum_of_squared_deviations = 0;
Review Comment:
for java, camel case is preferred
https://google.github.io/styleguide/javaguide.html#s5.3-camel-case
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/HistogramData.java:
##########
@@ -47,6 +47,9 @@ public class HistogramData implements Serializable {
private long numTopRecords;
private long numBottomRecords;
+ private double sum_of_squared_deviations;
Review Comment:
for java, camel case is preferred
https://google.github.io/styleguide/javaguide.html#s5.3-camel-case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
