bvolpato commented on code in PR #29511:
URL: https://github.com/apache/beam/pull/29511#discussion_r1401287202


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -607,7 +607,7 @@ class BeamModulePlugin implements Plugin<Project> {
     def google_code_gson_version = "2.10.1"
     def google_oauth_clients_version = "1.34.1"
     // Try to keep grpc_version consistent with gRPC version in 
google_cloud_platform_libraries_bom
-    def grpc_version = "1.56.1"
+    def grpc_version = "1.59.0"

Review Comment:
   It should be `1.58.0` to match libraries-bom 26.26.0
   
   
   checked with
   ```
   cd /tmp; wget 
https://repo1.maven.org/maven2/com/google/cloud/libraries-bom/26.26.0/libraries-bom-26.26.0.pom
 -O base.pom && mvn help:effective-pom -f base.pom -Doutput=effective.pom && 
cat effective.pom | grep -v 'dependencyManagement' > cleanup.pom && mvn 
dependency:tree -f cleanup.pom
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to