Abacn commented on code in PR #29533:
URL: https://github.com/apache/beam/pull/29533#discussion_r1406324459
##########
sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/ClickHouseIO.java:
##########
@@ -111,7 +111,9 @@
* <tr><td>{@link TableSchema.TypeName#BOOL}</td> <td>{@link
Schema.TypeName#BOOLEAN}</td></tr>
* </table>
*
- * Nullable row columns are supported through Nullable type in ClickHouse.
+ * Nullable row columns are supported through Nullable type in ClickHouse.
Adding support for <a
Review Comment:
This is javadoc. The statement "Adding support ..." sounds like an
announcement and consider moving it to [CHANGES.md
](https://github.com/apache/beam/blob/master/CHANGES.md)
For here, consider phrasing like "Low cardinality hint is supported through
LowCardinality DataType in ClickHouse."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
