m-trieu commented on code in PR #29592:
URL: https://github.com/apache/beam/pull/29592#discussion_r1421180847
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationState.java:
##########
@@ -120,8 +121,9 @@ private void forceExecute(Work work) {
}
/** Adds any work started before the refreshDeadline to the GetDataRequest
builder. */
- public List<Windmill.KeyedGetDataRequest> getKeysToRefresh(Instant
refreshDeadline) {
- return activeWorkState.getKeysToRefresh(refreshDeadline);
+ public List<Windmill.KeyedGetDataRequest> getKeysToRefresh(
Review Comment:
If list shouldn't be mutated by caller, use `ImmutableList`
go/java-practices/choosing-collections#immutable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
