je-ik commented on a change in pull request #12551:
URL: https://github.com/apache/beam/pull/12551#discussion_r470627537
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -1226,7 +1227,7 @@ public TimerInternals timerInternals() {
* fire time of the timer. Used for calculating the output watermark hold.
This avoids fetching
* timer data from the state backend which is expensive if done for each
timer.
*/
- private final PriorityQueue<Long> outputTimestampQueue;
+ private final TreeMultiset<Long> outputTimestamps = TreeMultiset.create();
Review comment:
I don't know the internal details of TreeMultiset, but I'd suppose it to
be pretty much the same as Map<Long, Integer> in terms of performance. Removing
the outputTimestamps entirely seems to be the best option. I'll try that and
let you know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
