riteshghorse commented on PR #28564: URL: https://github.com/apache/beam/pull/28564#issuecomment-1864975748
R: @tvalentyn this is ready for review Changes to note: 1. Changed the artifact comparison logic to ignore the type payload field since that has unique hashes 2. The external transform test failure was because of the `ExpansionServiceServicer` not having artifact service method. So added that. Confirmed this by running a multi-language pipleine successfully - [Job Link](https://pantheon.corp.google.com/dataflow/jobs/us-central1/2023-12-20_10_40_53-3162726322772484431;bottomTab=WORKER_LOGS;graphView=0;logsSeverity=INFO?pageState=(%22dfTime%22:(%22s%22:%222023-12-20T18:40:53.940Z%22,%22e%22:%222023-12-20T18:44:14.315Z%22))&project=google.com:clouddfe) 3. The staging logic stays in `stager.py` since we ulitmately call `create_job_resources` from `python_sdk_dependencies()` which is invoked during environment creation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
