lostluck opened a new pull request, #30072:
URL: https://github.com/apache/beam/pull/30072
Adds initial TestStream support for Prism for #29917.
* Handles watermark advancement.
* Multiple Outputs (though, this is untested until covered by Python, as Go
doesn't permit tag specification, however, the same lookup mechanism remains in
the single output case)
* Handles arbitrary element bytes.
* Handles being consumed as a side input.
A bit of light experimentation on handling design puts most test stream
related code into a single file, and uses an interface to delegate the
execution of events to the different events themeselves.
The only easily testable logic outside of a pipeline execution context would
be popping events from a queue. But as the alternative to correct popping is a
pipeline freeze and crash (pending elements remaining, but nothing to trigger
their processing), these are omitted.
The only included logic that isn't currently covered is Processing Time
handling, though the core is present in this PR. TestStreams with
ProcessingTime events will be hard failed at job submission time for now. This
is no great loss as Prism doesn't meaningfully handle ProcessingTime events at
all, and that will require it's own coordination to insert their executions in
the queue.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]