lukecwik commented on a change in pull request #12567:
URL: https://github.com/apache/beam/pull/12567#discussion_r471584362
##########
File path: runners/jet/build.gradle
##########
@@ -78,6 +78,22 @@ task validatesRunnerBatch(type: Test) {
exclude '**/SplittableDoFnTest.class' //Splittable DoFn functionality
not yet in the runner
excludeCategories 'org.apache.beam.sdk.testing.UsesBundleFinalizer'
}
+ filter {
+ //Jet Runner doesn't current support @RequiresTimeSortedInput
annotation.
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$StateTests.*TimeSortedInput*'
+
+ //Event type not supported in TestStream: class
org.apache.beam.sdk.testing.AutoValue_TestStream_ProcessingTimeEvent
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$TimerTests.testOutputTimestampWithProcessingTime'
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$TimerTests.testProcessingTimeTimerCanBeReset'
+
+ //unbounded streams created from bounded sources not supported by Jet
Runner
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$TimerTests.testTwoTimersSettingEachOtherWithCreateAsInputUnbounded'
+
+ //timer output timestamps not supported by Jet Runner
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$TimerTests.testOutputTimestamp'
+
+ excludeTestsMatching
'org.apache.beam.sdk.testing.PAssertTest.testAssertionSiteIsCaptured*'
Review comment:
Lets exclude test categories when possible based upon missing features
within the runner. This will allow additional tests to be added without needing
the exclusion lists of each runner to be updated.
```suggestion
excludeCategories 'org.apache.beam.sdk.testing.UsesBundleFinalizer'
//Jet Runner doesn't current support @RequiresTimeSortedInput
annotation.
excludeCategories
'org.apache.beam.sdk.testing.UsesRequiresTimeSortedInput'
//Event type not supported in TestStream: class
org.apache.beam.sdk.testing.AutoValue_TestStream_ProcessingTimeEvent
excludeCategories
'org.apache.beam.sdk.testing.UsesTestStreamWithProcessingTime'
}
filter {
// unbounded streams created from bounded sources not supported by
Jet Runner
excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$TimerTests.testTwoTimersSettingEachOtherWithCreateAsInputUnbounded'
// timer output timestamps not supported by Jet Runner
excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$TimerTests.testOutputTimestamp'
excludeTestsMatching
'org.apache.beam.sdk.testing.PAssertTest.testAssertionSiteIsCaptured*'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
