Abacn commented on code in PR #30283:
URL: https://github.com/apache/beam/pull/30283#discussion_r1486826728
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -488,6 +488,7 @@ public static void main(String[] args) throws Exception {
"%s cannot be main() class with beam_fn_api enabled",
StreamingDataflowWorker.class.getSimpleName());
+ LOG.info("Creating StreamingDataflowWorker from options: {}", options);
Review Comment:
Is this a debug leftover or consider change to LOG.debug? I see sometimes
pipeline options contain sensitive info (server ip, credential file name, etc,
if user defined their own pipeline options) so we may refrain from log full
pipeline option.
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##########
@@ -107,6 +111,29 @@ private static Endpoints.ApiServiceDescriptor
getApiServiceDescriptor(String des
return apiServiceDescriptorBuilder.build();
}
+ public static String removeNestedKey(String jsonString, String keyToRemove)
throws Exception {
Review Comment:
Yeah, leave it is fine. Seemingly it introduced a new dependency
jackson_databind, but since this is also a dependency of java_core, it does not
matter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
