volatilemolotov commented on code in PR #30344: URL: https://github.com/apache/beam/pull/30344#discussion_r1498385140
########## .test-infra/metrics/grafana/provisioning/alerts/flaky_test.yaml: ########## @@ -0,0 +1,149 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +apiVersion: 1 +groups: + - orgId: 1 + name: flaky-test + folder: General Alerting + interval: 1m + rules: + - uid: flaky_test + title: flaky_test + condition: E + data: + - refId: A + relativeTimeRange: + from: 600 + to: 0 + datasourceUid: beampsql + model: + editorMode: code + format: table + hide: false + intervalMs: 1000 + maxDataPoints: 43200 + rawQuery: true + rawSql: "SELECT COUNT(run_id), CAST (github_workflows.workflow_id AS TEXT), name AS workflow_name , filename AS workflow_filename , dashboard_category , github_workflows.url AS workflow_url \nFROM github_workflow_runs INNER JOIN github_workflows\nON github_workflow_runs.workflow_id = github_workflows.workflow_id \nWHERE status = 'failure' \nGROUP BY github_workflows.workflow_id, workflow_name, workflow_filename" + refId: A + - refId: B + relativeTimeRange: + from: 600 + to: 0 + datasourceUid: beampsql + model: + datasource: + type: postgres + uid: beampsql + editorMode: code + format: table + hide: false + intervalMs: 1000 + maxDataPoints: 43200 + rawQuery: true + rawSql: SELECT MAX(threshold), CAST(workflow_id AS TEXT) FROM github_workflows GROUP BY workflow_id + refId: B + - refId: C + relativeTimeRange: + from: 600 + to: 0 + datasourceUid: __expr__ + model: + conditions: + - evaluator: + params: + - 0 + - 0 + type: gt + operator: + type: and + query: + params: [] + reducer: + params: [] + type: avg + type: query + datasource: + name: Expression + type: __expr__ + uid: __expr__ + expression: 30 * $B + hide: false + intervalMs: 1000 + maxDataPoints: 43200 + refId: C + type: math + - refId: D + relativeTimeRange: + from: 600 + to: 0 + datasourceUid: __expr__ + model: + conditions: + - evaluator: + params: + - 0 + - 0 + type: gt + operator: + type: and + query: + params: [] + reducer: + params: [] + type: avg + type: query + datasource: + name: Expression + type: __expr__ + uid: __expr__ + expression: $C - $A + hide: false + intervalMs: 1000 + maxDataPoints: 43200 + refId: D + type: math + - refId: E + relativeTimeRange: + from: 600 + to: 0 + datasourceUid: __expr__ + model: + conditions: + - evaluator: + params: + - 0 + - 0 + type: lt + operator: + type: and + query: + params: [] + reducer: + params: [] + type: avg + type: query + datasource: + name: Expression + type: __expr__ + uid: __expr__ + expression: D + intervalMs: 1000 + maxDataPoints: 43200 + refId: E + type: threshold Review Comment: Basically the math operation of `failed_runs ` minus `threshold`. If negative alert. That was the way to have threshold defined within the data instead of grafana as grafana has a very simple engine for that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
