hjtran opened a new pull request, #30559: URL: https://github.com/apache/beam/pull/30559
LengthPrefixCoder doesn't define `to_type_hint` even though it seems pretty well defined. I've implemented it by just inferring it from its value coder. Motivating use case - we have some debug tools that infer the types of pcollections based on `to_type_hint`. The LPCoder is used in a lot of places. Bonus/unrelated change - I've pulled out the GitHub issue referenced in the `NotImplementedError` raised by `to_type_hint`. Every time I run into this error, I check the github issue and get more confused. It doesn't seem useful to refer to it in the error message, but does still seem relevant, so I pulled it out into a comment. *Testing Done* I haven't actually run the new unit test I wrote since I'm struggling to get my python sdk dev environment up (I've posted on the dev@ mailing list). Hoping the GH Action can just do it for me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
