tvalentyn commented on code in PR #30843:
URL: https://github.com/apache/beam/pull/30843#discussion_r1550554929
##########
sdks/python/setup.py:
##########
@@ -368,7 +372,6 @@ def get_portability_package_data():
'grpcio>=1.33.1,!=1.48.0,<2',
'hdfs>=2.1.0,<3.0.0',
'httplib2>=0.8,<0.23.0',
- 'js2py>=0.74,<1',
Review Comment:
Also let's reference the issue in JS2Py's tracker
##########
sdks/python/setup.py:
##########
@@ -368,7 +372,6 @@ def get_portability_package_data():
'grpcio>=1.33.1,!=1.48.0,<2',
'hdfs>=2.1.0,<3.0.0',
'httplib2>=0.8,<0.23.0',
- 'js2py>=0.74,<1',
Review Comment:
we can simplify it via an environmental marker:
https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#platform-specific-dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
