JayajP commented on code in PR #31000:
URL: https://github.com/apache/beam/pull/31000#discussion_r1569127726
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySinkMetrics.java:
##########
@@ -106,15 +106,15 @@ static Counter createRPCRequestCounter(RpcMethod method,
String rpcStatus, Strin
* <p>'RpcLatency-Method:{method};'
*
* @param method StorageWriteAPI method associated with this metric.
- * @return Histogram with exponential buckets with a sqrt(2) growth factor.
+ * @return Histogram with exponential buckets with a size 2 growth factor.
*/
static Histogram createRPCLatencyHistogram(RpcMethod method) {
LabeledMetricNameUtils.MetricNameBuilder nameBuilder =
LabeledMetricNameUtils.MetricNameBuilder.baseNameBuilder(RPC_LATENCY);
nameBuilder.addLabel(RPC_METHOD, method.toString());
MetricName metricName = nameBuilder.build(METRICS_NAMESPACE);
- HistogramData.BucketType buckets = HistogramData.ExponentialBuckets.of(1,
34);
+ HistogramData.BucketType buckets = HistogramData.ExponentialBuckets.of(0,
17);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
