scwhittle commented on code in PR #30693:
URL: https://github.com/apache/beam/pull/30693#discussion_r1574410652
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/MapTaskExecutor.java:
##########
@@ -107,6 +107,8 @@ public void execute() throws Exception {
}
throw exn;
}
+ } finally {
+ executionStateTracker.reset();
Review Comment:
Reset also resets additional state than just the bundle elapsed tracking and
it is harder to verify it is correct.
How about instead clearing the bundle lull tracking in to
ExecutionStateTracker::deactivate as well which is called by the stateCloser
returned by activate above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
