volatilemolotov commented on PR #30847:
URL: https://github.com/apache/beam/pull/30847#issuecomment-2073509133
> > > Could you tell me the outcome of your testing these changes in a new
GCP project, not apache-beam-testing.
> >
> >
> > Tested it out in a project that only had APIs enabled and a default VPC.
It works once i provided the subnet , router and nat
>
> Could you explain your testing approach because the following in
.test-infra/terraform/google-cloud-platform/google-kubernetes-engine/prerequisites.tf:
>
> ```
> // Query the Service Account.
> data "google_service_account" "default" {
> depends_on = [google_project_service.required]
> account_id = var.service_account_id
> }
> ```
>
> should have given you an error when you tested because
https://github.com/apache/beam/pull/30847/files#diff-e53f48e6ee35cb4d93d7b0750674c071edb78e05e90cbadda94492ef2be95cc1R27
in
`.test-infra/terraform/google-cloud-platform/google-kubernetes-engine/beam-utility.apache-beam-testing.tfvars`
(`service_account_id =
"[email protected]"`) is an email
and not the service account ID.
In `google_service_account` datasource email is allowed
https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/service_account#argument-reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
