fbiville commented on code in PR #31129:
URL: https://github.com/apache/beam/pull/31129#discussion_r1584392474
##########
it/neo4j/src/main/java/org/apache/beam/it/neo4j/Neo4jResourceManager.java:
##########
@@ -189,11 +194,26 @@ public String getAdminPassword() {
return adminPassword;
}
+ private static String formatWaitOption(DatabaseWaitOption waitOption) {
+ if (waitOption instanceof DatabaseWaitInSeconds) {
+ return String.format("WAIT %d SECONDS", ((DatabaseWaitInSeconds)
waitOption).getSeconds());
+ }
+ if (waitOption == DatabaseWait.WAIT) {
+ return "WAIT";
+ }
+ if (waitOption == DatabaseNoWait.NO_WAIT || waitOption == null) {
+ return "NOWAIT";
Review Comment:
note: I don't think `NOWAIT` is a good default, but I did this in order to
preserve behavior with the current implementation. I wonder if changing the
default behavior would be OK here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
