tvalentyn commented on code in PR #31170:
URL: https://github.com/apache/beam/pull/31170#discussion_r1591557754
##########
sdks/python/apache_beam/typehints/intrinsic_one_ops_test.py:
##########
@@ -30,7 +30,7 @@ class IntrinsicOneOpsTest(unittest.TestCase):
def testOperationsOrder(self):
if sys.version_info >= (3, 12):
dis_order = dis.__dict__['_intrinsic_1_descs']
- beam_order = list()
+ beam_order = []
Review Comment:
nit: use [list
comprehensions](https://docs.python.org/3/tutorial/datastructures.html#list-comprehensions)
for a more Pythonic syntax. e.g.
`beam_ops = [fn.__name_upper() for fn in intrinsic_one_ops.INT_ONE_OPS]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
