Abacn commented on code in PR #31290:
URL: https://github.com/apache/beam/pull/31290#discussion_r1600403810
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -3061,32 +3061,13 @@ class BeamModulePlugin implements Plugin<Project> {
}
project.ext.toxTask = { name, tox_env, posargs='' ->
project.tasks.register(name) {
- dependsOn setupVirtualenv
- dependsOn ':sdks:python:sdist'
- if (project.hasProperty('useWheelDistribution')) {
Review Comment:
this was added in #28385 and there was some discussion there. Do they still
apply?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
