tvalentyn commented on code in PR #31291:
URL: https://github.com/apache/beam/pull/31291#discussion_r1619172898
##########
sdks/python/apache_beam/ml/transforms/tft.py:
##########
@@ -337,16 +337,16 @@ def __init__(
name: Optional[str] = None):
"""
This functions is used to map the element to a positive index i for
- which bucket_boundaries[i-1] <= element < bucket_boundaries[i],
- if it exists. If input < bucket_boundaries[0], then element is
- mapped to 0. If element >= bucket_boundaries[-1], then element is
+ which `bucket_boundaries[i-1] <= element < bucket_boundaries[i]`,
+ if it exists. If `input < bucket_boundaries[0]`, then element is
+ mapped to 0. If `element >= bucket_boundaries[-1]`, then element is
mapped to len(bucket_boundaries). NaNs are mapped to
len(bucket_boundaries).
Args:
columns: A list of column names to apply the transformation on.
- bucket_boundaries: A rank 2 Tensor or list representing the bucket
- boundaries sorted in ascending order.
+ bucket_boundaries: An iterable of ints or floats representing the bucket
+ boundaries orted in ascending order.
Review Comment:
```suggestion
boundaries. Must be sorted in ascending order.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
