lostluck commented on code in PR #31472:
URL: https://github.com/apache/beam/pull/31472#discussion_r1623496915
##########
sdks/go/pkg/beam/runners/prism/internal/unimplemented_test.go:
##########
@@ -52,7 +52,6 @@ func TestUnimplemented(t *testing.T) {
{pipeline: primitives.TriggerAfterProcessingTime},
{pipeline: primitives.TriggerAfterSynchronizedProcessingTime},
{pipeline: primitives.TriggerElementCount},
- {pipeline: primitives.TriggerNever},
Review Comment:
Tests removed from this list *must* be added to another test that expects
them to pass. Otherwise we're opening a test regression gap for ourselves down
the road.
So, if you're removing this because TestUnimplmented started to fail, then
you *must* move it to the TestImplmenented list down below.
If this test *didn't* start to fail, then we should leave it here to show we
aren't fully done work on TriggerNever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
