ahmedabu98 commented on code in PR #31470:
URL: https://github.com/apache/beam/pull/31470#discussion_r1624885356
##########
sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java:
##########
@@ -194,7 +199,28 @@ public PCollectionRowTuple expand(PCollectionRowTuple
input) {
SchemaTransform underlyingTransform =
new
ManagedSchemaTransformProvider(getSupportedIdentifiers()).from(managedConfig);
- return input.apply(underlyingTransform);
+ return inputTuple.apply(underlyingTransform);
+ }
+
+ @VisibleForTesting
+ static PCollectionRowTuple resolveInput(PInput input) {
Review Comment:
Will have to think about this one some more. From what I see, it's possible
if ManagedTransform returns a `POutput`, but that may be harmful. POutput
doesn't implement `apply()` so it would prevent users from chaining downstream
transforms.
We could also create an abstraction between PCollectionRowTuple and
PCollection<Row> but that feels a little messy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
