aaltay commented on code in PR #31511:
URL: https://github.com/apache/beam/pull/31511#discussion_r1628066608
##########
sdks/python/apache_beam/io/textio.py:
##########
@@ -927,7 +927,12 @@ def append(dest):
@append_pandas_args(
pandas.read_csv, exclude=['filepath_or_buffer', 'iterator'])
- def ReadFromCsv(path: str, *, splittable: bool = True, **kwargs):
+ def ReadFromCsv(
+ path: str,
+ *,
+ splittable: bool = True,
+ label: str = 'ReadFromCsv',
Review Comment:
Would not this be backward incompatible if **kwargs already has a label key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
