robertwb commented on PR #31508: URL: https://github.com/apache/beam/pull/31508#issuecomment-2150930235
It can cause data loss for pipeline update. Suppose one has (as a simplified example) ``` p | ReadFromPubSub(topic1) | SomeAnalysis() | WriteToPubSub(somewhere) p | ReadFromPubSub(topic2) | SomeAnalysis() | WriteToPubSub(somewhere else) ``` If I modify the pipeline and remove the first line (and auto_unique_labels is set), the stages from the second line would now inherit the non-uniquified names that would collide with those of the first. Any state that was present in the first (now deleted) line would then get matched up and used in the updated pipeline as if it were part of the second. This includes in-flight messages (e.g. messages from `topic1` could get written to `somewhere else`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
