arunpandianp commented on code in PR #31298:
URL: https://github.com/apache/beam/pull/31298#discussion_r1634399562
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreams.java:
##########
@@ -62,7 +62,7 @@
*/
@ThreadSafe
@Internal
-public class GrpcWindmillStreamFactory implements StatusDataProvider {
+public class GrpcWindmillStreams implements StatusDataProvider {
Review Comment:
I think GrpcWindmillStreams is better than GrpcWindmillStreamFactory, since
this class is not merely a factory creating instances, but it also keeps track
of the created instances and does health checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
