robertwb commented on code in PR #31558:
URL: https://github.com/apache/beam/pull/31558#discussion_r1638507846
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/SchemaTransform.java:
##########
@@ -33,5 +36,39 @@
* compatibility guarantees and it should not be implemented outside of the
Beam repository.
*/
@Internal
-public abstract class SchemaTransform
- extends PTransform<PCollectionRowTuple, PCollectionRowTuple> {}
+public abstract class SchemaTransform extends PTransform<PCollectionRowTuple,
PCollectionRowTuple> {
+ private @Nullable Row configurationRow;
Review Comment:
It feels like putting these (optional) private variables as part of the base
class violates separation of concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
