Amar3tto commented on code in PR #31600:
URL: https://github.com/apache/beam/pull/31600#discussion_r1640134166
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java:
##########
@@ -816,6 +821,13 @@ public static FieldType iterable(FieldType elementType) {
/** Create a map type for the given key and value types. */
public static FieldType map(FieldType keyType, FieldType valueType) {
+ if (FieldType.BYTES.equals(keyType)) {
Review Comment:
I am not sure that it will cause spam, just one message per one creating of
`FieldType` with byte array key in a map.
It's not clear where to have this flag, because `FieldType` object may exist
independently of `Schema`, in such case we want to have a warning too. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
