bzablocki commented on code in PR #31476: URL: https://github.com/apache/beam/pull/31476#discussion_r1643303917
########## sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/data/Solace.java: ########## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.solace.data; + +import com.google.auto.value.AutoValue; +import com.solacesystems.jcsmp.BytesXMLMessage; +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import org.apache.beam.sdk.schemas.AutoValueSchema; +import org.apache.beam.sdk.schemas.annotations.DefaultSchema; +import org.apache.beam.sdk.schemas.annotations.SchemaFieldNumber; +import org.checkerframework.checker.nullness.qual.Nullable; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * A record to be written to a Solace topic. + * + * <p>You need to transform to {@link Solace.Record} to be able to write to Solace. For that, you + * can use the {@link Solace.Record.Builder} provided with this class. + * + * <p>For instance, to create a record, use the following code: + * + * <pre>{@code + * Solace.Record record = Solace.Record.builder() + * .setMessageId(messageId) + * .setSenderTimestamp(timestampMillis) + * .setPayload(payload) + * .build(); + * }</pre> + * + * Setting the message id and the timestamp is mandatory. + */ +public class Solace { + + public static class Queue { + private final String name; + + private Queue(String name) { + this.name = name; + } + + public static Queue fromName(String name) { + return new Queue(name); + } + + public String getName() { + return name; + } + } + + public static class Topic { + private final String name; + + private Topic(String name) { + this.name = name; + } + + public static Topic fromName(String name) { + return new Topic(name); + } + + public String getName() { + return name; + } + } + + public enum DestinationType { + TOPIC, + QUEUE + } + + @AutoValue + @DefaultSchema(AutoValueSchema.class) + public abstract static class Destination { + @SchemaFieldNumber("0") + public abstract String getName(); + + @SchemaFieldNumber("1") + public abstract DestinationType getType(); + + public static Builder builder() { + return new AutoValue_Solace_Destination.Builder(); + } + + @AutoValue.Builder + public abstract static class Builder { + public abstract Builder setName(String name); + + public abstract Builder setType(DestinationType type); + + public abstract Destination build(); + } + } + + @AutoValue + @DefaultSchema(AutoValueSchema.class) + public abstract static class Record { Review Comment: ad 2, 3 - done. I left only the necessary `@Nullable` annotations and added documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
